Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add timing log to check_database #14667

Merged
merged 5 commits into from
Jan 10, 2024
Merged

add timing log to check_database #14667

merged 5 commits into from
Jan 10, 2024

Conversation

ghost-not-in-the-shell
Copy link
Contributor

Explain your changes:
This PR adds timing log to Persistent_frontier.Instance.check_database. This is for the debugging of a long async cycle that we saw on testworld-2-0.
See: https://app.zenhub.com/workspaces/protocol-eng-64d12d77bff4a91f97f60205/issues/gh/minaprotocol/mina/14665

Explain how you tested your changes:
*

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them
  • Closes #0000

@ghost-not-in-the-shell ghost-not-in-the-shell requested a review from a team as a code owner December 6, 2023 20:27
@ghost-not-in-the-shell
Copy link
Contributor Author

!ci-build-me

@deepthiskumar
Copy link
Member

!approved-for-mainnet

@ghost-not-in-the-shell
Copy link
Contributor Author

!ci-build-me

@ghost-not-in-the-shell
Copy link
Contributor Author

!ci-build-me

@ghost-not-in-the-shell
Copy link
Contributor Author

!ci-build-me

@mrmr1993
Copy link
Member

!approved-for-mainnet

@mrmr1993 mrmr1993 merged commit bb41ad3 into rampup Jan 10, 2024
35 of 36 checks passed
@mrmr1993 mrmr1993 deleted the add-timing-logs-to-check-database branch January 10, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthiskumar deepthiskumar deepthiskumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghost-not-in-the-shell @deepthiskumar @mrmr1993